-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various performance optimizations #310
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove linear gradient commands, it comes with a hefty performance penalty to render a gradient layer with blended colors - Remove the shadow from the command views - Add debouncing when editing application names - Add new `AppCheckbox` & `AppToggle` - Replace all use of `Toggle` with wither `AppCheckbox` or `AppToggle` - Fix warnings about using `var` instead of `let` - Refactor performance data generator in `ContentStore`
The cool thing about this is now we have more control over the "system controls". |
The checkbox differs from the system one because I think that uses two bitmaps as it has gradients, among other things. |
Test: succeeded ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems odd, but having the built-in toggles in reusable views seems
like a bit of a performance hit in SwiftUI.
So, I ended up recreating the system controls.
Introducing
AppCheckbox
andAppToggle
.They look like this (the system one is also there for reference):
to render a gradient layer with blended colors
AppCheckbox
&AppToggle
Toggle
with witherAppCheckbox
orAppToggle
var
instead oflet
ContentStore